Fix PR comment scripts failing builds on permission denied - #329
Conversation
When downstream repos call ghbuild.yml without pull-requests: write permission, the PR comment scripts received a 403 Forbidden error and called sys.exit(1), failing the entire build. PR comments are informational and should never block the build. Changes: - Handle 401/403 errors gracefully in both pr_comment_start.py and pr_comment_finish.py (warn and continue instead of exit 1) - Add continue-on-error: true to both PR comment workflow steps as a safety net https://claude.ai/code/session_01R8Qifz4vasB9Yn7CRzhWPa
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
2 participants
Summary
smart-pcmt-vaxprequalcallghbuild.ymlwithoutpull-requests: writepermission, the PR comment scripts got a 403 Forbidden and calledsys.exit(1), failing the entire buildpr_comment_start.pyandpr_comment_finish.pynow print a warning and continue instead of exiting with error code 1continue-on-error: trueto both PR comment workflow steps inghbuild.ymlas a safety net — PR comments are informational and should never block the buildTest plan
smart-pcmt-vaxprequal) with a PR and verify the build no longer fails on the PR comment stepsmart-baseitself with a PR and verify PR comments still post successfully when permissions are correcthttps://claude.ai/code/session_01R8Qifz4vasB9Yn7CRzhWPa