Repository navigation
chore(skills): Add contribute-component maintainer skill - #4195
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
ola/contribute-component-skill
|
| Run status |
|
| Run duration | 02m 38s |
| Commit |
|
| Committer | olaonikosi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
17
|
|
|
0
|
|
|
837
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.59%
|
|
|---|---|
|
|
1578
|
|
|
382
|
Accessibility
99.09%
|
|
|---|---|
|
|
5 critical
5 serious
3 moderate
2 minor
|
|
|
76
|
…tions Replace data-whatinput focus guidance with :focus-visible, note that createStencil already sets box-sizing, and document when to extend the collection system in AGENTS.md and related skills. Co-authored-by: Cursor <cursoragent@cursor.com>
mannycarrera4
marked this pull request as ready for review
October 5, 2026 16:21
mannycarrera4
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a maintainer skill for contributing components to Canvas Kit, and aligns AGENTS.md / related skills with current focus, stencil, and collection guidance.
The contribute skill captures the process used to build SelectionGroup (#1969): gathering the spec from GitHub and Figma, choosing sibling components to copy, extending the collection system when appropriate, the Sana styling checklist, tests, and a PR summary template.
Also updates maintainer guidance so agents do not teach removed patterns (
data-whatinput/InputProvider), do not repeatboxSizing: 'border-box'insidecreateStencil(already injected), and know when to extend@workday/canvas-kit-react/collectionvs a plaincreateModelHook.Release Category
Documentation
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
skills/sana-canvas-kit-contribute-component/SKILL.md, thenreferences.md(collection decision, Sana styling checklist). Cross-check focus / box-sizing / collection notes inAGENTS.mdandmodules/docs/mdx/API_PATTERN_GUIDELINES.mdx.Areas for Feedback? (optional)
Particularly: whether the collection "when to use / when to skip" decision is clear enough for agents, and whether
skills/README.mdlisting the contribute skill as maintainer-only (while Storybook Overview stays consumer-only) is the right split.Testing Manually
skills/sana-canvas-kit-contribute-component/SKILL.mdand walk the checklist against a list-shaped component (e.g. SegmentedControl) and a non-collection component (e.g. Banner).data-whatinputfor focus suppression.boxSizing: 'border-box'on stencils.Screenshots or GIFs (if applicable)
N/A — docs and agent skills only.
Summary by CodeRabbit
:focus-visibleand a.focusclass for visual testing.