Skip to content

chore(skills): Add contribute-component maintainer skill - #4195

Merged
alanbsmith merged 3 commits into
masterfrom
ola/contribute-component-skill
Oct 5, 2026
Merged

alanbsmith merged 3 commits into
masterfrom
ola/contribute-component-skill

Conversation

@olaonikosi

@olaonikosi olaonikosi commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds a maintainer skill for contributing components to Canvas Kit, and aligns AGENTS.md / related skills with current focus, stencil, and collection guidance.

The contribute skill captures the process used to build SelectionGroup (#1969): gathering the spec from GitHub and Figma, choosing sibling components to copy, extending the collection system when appropriate, the Sana styling checklist, tests, and a PR summary template.

Also updates maintainer guidance so agents do not teach removed patterns (data-whatinput / InputProvider), do not repeat boxSizing: 'border-box' inside createStencil (already injected), and know when to extend @workday/canvas-kit-react/collection vs a plain createModelHook.

Release Category

Documentation


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

skills/sana-canvas-kit-contribute-component/SKILL.md, then references.md (collection decision, Sana styling checklist). Cross-check focus / box-sizing / collection notes in AGENTS.md and modules/docs/mdx/API_PATTERN_GUIDELINES.mdx.

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Particularly: whether the collection "when to use / when to skip" decision is clear enough for agents, and whether skills/README.md listing the contribute skill as maintainer-only (while Storybook Overview stays consumer-only) is the right split.

Testing Manually

  • Open skills/sana-canvas-kit-contribute-component/SKILL.md and walk the checklist against a list-shaped component (e.g. SegmentedControl) and a non-collection component (e.g. Banner).
  • Confirm AGENTS.md and API Pattern Guidelines no longer recommend data-whatinput for focus suppression.
  • Confirm styling / contribute skills tell agents not to set boxSizing: 'border-box' on stencils.

Screenshots or GIFs (if applicable)

N/A — docs and agent skills only.

Summary by CodeRabbit

  • Documentation
    • Updated accessibility guidance to recommend visible focus indicators using :focus-visible and a .focus class for visual testing.
    • Clarified when to use collection patterns for lists, grids, and other components with selection or keyboard navigation.
    • Added contributor guidance for building Canvas Kit components, including design review, implementation, testing, and validation workflows.
    • Clarified styling practices for focus indicators and automatic box sizing.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: Workday/canvas-kit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5033919c-d9c4-455b-be37-10fdf49bb0ea
📥 Commits

Reviewing files that changed from the base of the PR and between 7d7b082 and fc836ef.

📒 Files selected for processing (8)
  • AGENTS.md
  • modules/docs/mdx/API_PATTERN_GUIDELINES.mdx
  • skills/README.md
  • skills/sana-canvas-kit-builder/SKILL.md
  • skills/sana-canvas-kit-contribute-component/SKILL.md
  • skills/sana-canvas-kit-contribute-component/references.md
  • skills/sana-canvas-kit-review/SKILL.md
  • skills/sana-canvas-kit-styling/SKILL.md
 ________________________________________________________
< Your error handling is basically thoughts and prayers. >
 --------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cypress

cypress Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Workday/canvas-kit    Run #11674

Run Properties:  status check passed Passed #11674  •  git commit 02f06f5572 ℹ️: Merge fc836efad6ee41c8f979097af9ab1ec2e4e66b00 into 7d7b082072832ef2487df44d41d9...
Project Workday/canvas-kit
Branch Review ola/contribute-component-skill
Run status status check passed Passed #11674
Run duration 02m 38s
Commit git commit 02f06f5572 ℹ️: Merge fc836efad6ee41c8f979097af9ab1ec2e4e66b00 into 7d7b082072832ef2487df44d41d9...
Committer olaonikosi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 17
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 837
View all changes introduced in this branch ↗︎
UI Coverage  19.59%
  Untested elements 1578  
  Tested elements 382  
Accessibility  99.09%
  Failed rules  5 critical   5 serious   3 moderate   2 minor
  Failed elements 76  

…tions

Replace data-whatinput focus guidance with :focus-visible, note that
createStencil already sets box-sizing, and document when to extend the
collection system in AGENTS.md and related skills.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mannycarrera4
mannycarrera4 marked this pull request as ready for review October 5, 2026 16:21
@mannycarrera4
mannycarrera4 requested a review from a team as a code owner October 5, 2026 16:21
@alanbsmith
alanbsmith merged commit ad3e316 into master Oct 5, 2026
23 of 25 checks passed
@alanbsmith
alanbsmith deleted the ola/contribute-component-skill branch October 5, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants