Plugin Directory: Adjust lightbox trigger icon z-index to prevent menu overlap#691
Open
alanjacobmathew wants to merge 1 commit into
Open
Plugin Directory: Adjust lightbox trigger icon z-index to prevent menu overlap#691alanjacobmathew wants to merge 1 commit into
alanjacobmathew wants to merge 1 commit into
Conversation
Override the inherited z-index of the lightbox trigger icon so it sits behind the menu
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a visual bug where the screenshot lightbox trigger icon was overlapping the menu, on hovering the screenshot.
Fix
Added a z-index value for the trigger-icon, to override the inherited value.
Screenshots
Before:
After:
Refs
Closes: https://meta.trac.wordpress.org/ticket/8299