Skip to content

test: cover cleanup without presence table #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
floze-the-genius wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: cover cleanup without presence table #263

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18dd1bd
test: cover cleanup without presence table
floze-the-genius Aug 11, 2026
0f8c40b
Merge branch 'main' into test/262-cleanup-no-table
josephfusco Aug 14, 2026
1edc357
Merge branch 'main' into test/262-cleanup-no-table
josephfusco Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test-cli-command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,18 @@ public function test_cleanup_deletes_every_entry_regardless_of_age() {
$this->assertSame( array( '3 entries deleted.' ), WP_CLI::messages( 'success' ) );
}

/**
* @covers WP_Presence_CLI_Command::cleanup
*/
public function test_cleanup_reports_zero_without_a_table() {
add_filter( 'option_wp_presence_db_version', '__return_zero' );

$this->command->cleanup( array(), array( 'yes' => true ) );

@i-am-chitti i-am-chitti Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The confirm assertion here doesn't actually test the no-table code path.

cleanup() skips confirm() for two reasons - either the table is missing, or 'yes' => true was passed. This test passes 'yes' => true, so confirm() is already skipped, regardless of whether the no-table path fires. I confirmed this by removing the no-table early return from cleanup() and rerunning. It still passed.

The "yes flag skips confirm" behavior is already covered here test_cleanup_skips_the_prompt_with_the_yes_flag .

Suggested change
$this->command->cleanup( array(), array( 'yes' => true ) );
$this->command->cleanup( array(), array() );


$this->assertSame( array( '0 entries deleted.' ), WP_CLI::messages( 'success' ) );
$this->assertSame( array(), WP_CLI::messages( 'confirm' ) );
}

/**
* @covers WP_Presence_CLI_Command::cleanup
*/
Expand Down
Loading