fix(server-card): rename --version to --set-version (global flag clash)#89
Merged
Merged
Conversation
`faf server-card --version <v>` collided with commander's program-level `.version(VERSION, '-v, --version')` (cli.ts:48), so commander's built-in won and PRINTED the CLI version instead of setting the card's version field. Renamed the server-card option --version -> --set-version (options.setVersion); the global -v/--version is untouched. The old flag never worked (it printed the CLI version), so this is a pure fix, not a break. Verified: `server-card --set-version 9.9.9 --check` -> version 9.9.9; `faf --version` still prints the CLI version; `server-card --help` shows --set-version. Typecheck clean (the TS2688 bun-types note is pre-existing env). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Wolfe-Jam
added a commit
that referenced
this pull request
Jul 1, 2026
Version + CHANGELOG for the server-card flag-clash fix already merged (#89). Patch → inherits "The GIT Version" (no new edition). - package.json 7.0.1 → 7.0.2 - CHANGELOG: meta-stamp latest=v7.0.2 + [7.0.2] entry Publish via /pubpro after merge (npm + faf dual-publish + Homebrew). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (reported by wolfejam):
faf server-card --version <v>prints the CLI version instead of setting the card's version field.Cause: the
server-cardcommand's--version <version>option (cli.ts:195) collided with commander's program-level.version(VERSION, '-v, --version')(cli.ts:48) — the built-in wins, prints7.0.1, and exits before the field is set. The old flag never worked.Fix: rename the option
--version→--set-version(options.version→options.setVersion). The global-v/--versionis untouched.Verified (manual, no existing command-test harness):
server-card --set-version 9.9.9 --check"version": "9.9.9"faf --version7.0.1(global flag intact)server-card --help--set-version+ a note pointing at the global flagPure fix (the old flag was broken), so no migration for anyone who had it working — nobody did. Ship via
/pubproas 7.0.2 (this PR is the code fix only).— Assisted by Claude (Opus 4.8) · Approved by James Wolfe (@Wolfe-Jam)