Fix Linux build: add missing normalbrowserobject.cpp/.h to CMakeLists.txt#656
Open
fanlei wants to merge 2 commits into
Open
Fix Linux build: add missing normalbrowserobject.cpp/.h to CMakeLists.txt#656fanlei wants to merge 2 commits into
fanlei wants to merge 2 commits into
Conversation
….txt The share/normalbrowserobject.cpp and .h files were present in the legacy src/src.pro qmake project file but were never added to src/CMakeLists.txt during the migration to CMake. This caused a linker error when building on Linux: undefined reference to `NormalBrowserObject::NormalBrowserObject(WizMainWindow*, QWebEngineView*, QObject*)' Build environment: OS: Ubuntu 24.04.4 LTS (Noble Numbat) Kernel: 6.17.0-1028-oem Qt: 5.15.13 (system, /usr/lib/x86_64-linux-gnu) CMake: 3.28.3 GCC: 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building on Linux fails at the link stage with:
Root cause
share/normalbrowserobject.cppandshare/normalbrowserobject.hare present in the legacysrc/src.proqmake project file but were never added tosrc/CMakeLists.txtduring the migration to CMake, so they're excluded from the build (and never moc'd, since the header declaresQ_OBJECT).Fix
Added both files to the source/header lists in
src/CMakeLists.txt.Build environment
Testing
Verified a clean
cmake+make -j$(nproc)completes successfully and the resultingWizNotebinary launches, connects, authenticates, and renders its main window.