This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Conversation
Wszystko wygląda już w porządku
Owner
Author
|
Javadoc oraz UML do zadania są pod tym linkiem |
kowallus
suggested changes
Jan 26, 2021
kowallus
left a comment
kowallus
left a comment
Collaborator
There was a problem hiding this comment.
2.5 pts
Specific issues inlined in the code.
| @@ -0,0 +1,13 @@ | |||
| <component name="libraryTable"> | |||
Collaborator
There was a problem hiding this comment.
Commits polluted with project files
| public class DefaultCountingOutRhymer { | ||
|
|
||
| public static final int DEFAULT_VALUE = -1; | ||
| public static final int MAX = 12; |
| } | ||
|
|
||
| public boolean isFull() { | ||
| return total == 11; |
Collaborator
There was a problem hiding this comment.
Another constant. It is related to MAX (yet, the name is misinforming)
| } | ||
|
|
||
| public boolean callCheck() { | ||
| return total == -1; |
|
|
||
| protected int peekaboo() { | ||
| if (callCheck()) | ||
| return -1; |
|
|
||
| public defaultCountingOutRhymer temp = new defaultCountingOutRhymer(); | ||
|
|
||
| public DefaultCountingOutRhymer temp = new DefaultCountingOutRhymer(); |
Collaborator
There was a problem hiding this comment.
should be private and final
| public class HanoiRhymer extends DefaultCountingOutRhymer { | ||
|
|
||
| int totalRejected = 0; | ||
| int totalRejected = 0; |
| @Override | ||
| public defaultCountingOutRhymer GetStandardRhymer() { | ||
| return new defaultCountingOutRhymer(); | ||
| public DefaultCountingOutRhymer GetStandardRhymer() { |
Collaborator
There was a problem hiding this comment.
names of methods start from a lowercase (e.g. getStandardRhymer())
|
|
||
| class RhymersDemo { | ||
|
|
||
| public static final int INT_15 = 15; |
Collaborator
There was a problem hiding this comment.
such extracting constants doesn't make sense to me
Comment on lines
5
to
6
| final public int value; | ||
| public Node prev, next; |
Collaborator
There was a problem hiding this comment.
What about encapsulation?
Owner
Author
|
Added fixes and part of 2.x.x labs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Przepraszam za spóźnienie :(