Skip to content
This repository was archived by the owner on May 13, 2026. It is now read-only.

Feature/ace3 milestone 8 Final - #149

Merged
Wishmaster117 merged 4 commits into
feature/ace3-migrationfrom
feature/ace3-Milestone-8
Apr 3, 2026
Merged

Feature/ace3 milestone 8 Final#149
Wishmaster117 merged 4 commits into
feature/ace3-migrationfrom
feature/ace3-Milestone-8

Conversation

@Wishmaster117

Copy link
Copy Markdown
Owner

No description provided.

@Wishmaster117
Wishmaster117 merged commit ced0a1f into feature/ace3-migration Apr 3, 2026
4 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ade496a36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +650 to +651
return MultiBot.talent.getActiveTabState() == MultiBot.TalentTabStates.TALENTS
and MultiBot.talent.hasUnspentTalentPoints()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Apply available after last point is allocated

hasTalentsApplySelection only returns true while unspent points remain, but onTalentLeftClick refreshes Apply visibility after every click. In the Talents tab, allocating the final point sets points to 0 and immediately hides Apply, so users can no longer submit the completed build they just configured (unless they had clicked Apply earlier with points still unspent). This breaks the new Talents-tab apply flow for the common “spend all points, then apply” path.

Useful? React with 👍 / 👎.

@Wishmaster117
Wishmaster117 deleted the feature/ace3-Milestone-8 branch April 6, 2026 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant