Remove use of deprecated "raw" poly1305 package - #150
Open
joshuaoco wants to merge 1 commit into
Open
Conversation
joshuaoco
force-pushed
the
joshua/remove-poly1305-dependency
branch
from
July 19, 2026 07:51
a9294de to
5d3841c
Compare
The poly1305 package is marked explicitly as deprecated for general use, and while our usage here is trivial (a single constant), we might as well use the blessed chacha20poly1305 alternative. The only change is poly1305.TagSize -> chacha20poly1305.Overhead. This exact swap is recommended in the poly1305 package. ``` // TagSize is the size, in bytes, of a poly1305 authenticator. // // For use with golang.org/x/crypto/chacha20poly1305, chacha20poly1305.Overhead // can be used instead. const TagSize = 16 ``` I also think it reads more clearly now :) Signed-off-by: Joshua O'Connor <joshua@joshuao.com>
joshuaoco
force-pushed
the
joshua/remove-poly1305-dependency
branch
from
July 19, 2026 07:52
5d3841c to
bfa2df6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The poly1305 package is marked explicitly as deprecated for general use, and while our usage here is trivial (a single constant), we might as well use the blessed chacha20poly1305 alternative.
The only change is
poly1305.TagSize->chacha20poly1305.Overhead.This exact swap is recommended in the
poly1305package.I also think it reads more clearly now :)