Skip to content

Cluster-tool: Drop base_per_transaction_net_usage from generated genesis #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heifner merged 2 commits into from
Jul 15, 2026
Merged

Cluster-tool: Drop base_per_transaction_net_usage from generated genesis #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8beec3d
cluster-tool: drop base_per_transaction_net_usage from generated genesis
heifner Jul 15, 2026
4747809
cluster-tool: assert generated genesis omits base_per_transaction_net…
heifner Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/production-bootstrap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,10 +381,10 @@ Not on-chain actions, but the remaining config the tooling sets so the picture i
| `max_block_net_usage` | `1048576` | `deferred_trx_expiration_window` | `600` |
| `target_block_net_usage_pct` | `10000` | `max_transaction_delay` | `3888000` |
| `max_transaction_net_usage` | `524288` | `max_inline_action_size` | `524287` |
| `base_per_transaction_net_usage` | `12` | `max_inline_action_depth` | `10` |
| `net_usage_leeway` | `500` | `max_authority_depth` | `10` |
| `context_free_discount_net_usage_num/den` | `20 / 100` | `max_block_cpu_usage` | `400000` |
| `target_block_cpu_usage_pct` | `10` | `max_transaction_cpu_usage` | `375000` |
| `net_usage_leeway` | `500` | `max_inline_action_depth` | `10` |
| `context_free_discount_net_usage_num/den` | `20 / 100` | `max_authority_depth` | `10` |
| `target_block_cpu_usage_pct` | `10` | `max_block_cpu_usage` | `400000` |
| `max_transaction_cpu_usage` | `375000` | | |

### nodeop arguments & topology
- Extra args (every node): `vote-threads = 4`, `max-transaction-time = -1`, `abi-serializer-max-time-ms =
Expand Down
1 change: 0 additions & 1 deletion packages/cluster-tool/src/config/renderers/ClusterConfigGenesisRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export class ClusterConfigGenesisRenderer implements Renderer {
max_block_net_usage: 1_048_576,
target_block_net_usage_pct: 10_000,
max_transaction_net_usage: 524_288,
base_per_transaction_net_usage: 12,

@huangminghuang huangminghuang Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Please add a regression assertion for the removed field

This changes the generated genesis schema, but no test verifies that base_per_transaction_net_usage is absent. The existing genesis-renderer tests still pass if this deletion is reverted. Please add an assertion in packages/cluster-tool/tests/config/NodeConfig.test.ts against the parsed initial_configuration, as required by the repository test policy.

@heifner heifner Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 4747809: NodeConfig.test.ts now parses the rendered genesis and asserts initial_configuration has no base_per_transaction_net_usage, anchored by a neighbor-field check so the assertion reads the right object. Reverting the renderer deletion fails the suite.

net_usage_leeway: 500,
context_free_discount_net_usage_num: 20,
context_free_discount_net_usage_den: 100,
Expand Down
8 changes: 8 additions & 0 deletions packages/cluster-tool/tests/config/NodeConfig.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,5 +115,13 @@ describe("NodeConfig", () => {
const genesis = JSON.parse(fixtureConfig().genesis.render())
expect(genesis.initial_finalizer_key).toBeUndefined()
})

it("does not emit the removed base_per_transaction_net_usage parameter", () => {
const genesis = JSON.parse(fixtureConfig().genesis.render())
expect(genesis.initial_configuration.net_usage_leeway).toBe(500)
expect(genesis.initial_configuration).not.toHaveProperty(
"base_per_transaction_net_usage"
)
})
})
})