Validate outpost client startup configuration#534
Draft
huangminghuang wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--signature-providereth_chainIdduring startup using checkeduint32parsinggetGenesisHash, and compare an optional configured expected genesis hashWhy
Outpost client configuration previously resolved signers through the general provider registry, so anonymous/default/programmatically created aliases could satisfy a signer reference. Ethereum chain IDs and Solana cluster identities also were not verified against the configured RPC endpoint during startup. A misconfigured node could therefore boot with the wrong signer or remote chain and fail later in relay operation.
This change fails startup with a configuration error before relay work begins. The legacy three-field Ethereum client format remains supported and does not perform an identity RPC when no chain ID is configured. Solana endpoints are always identity-checked as required.
Validation
test_signature_provider_manager_plugin,test_outpost_ethereum_client_plugin, andtest_outpost_solana_client_pluginjson_rpc_client_tests: 10/10 passedgit diff --checkNotes
This branch is based directly on
origin/master; it does not include or depend on PR #516.