batch_operator: drop the operator-side bootstrap push#521
Closed
jglanz wants to merge 1 commit into
Closed
Conversation
The genesis advance (epoch 0 -> 1) is a SYSTEM responsibility, not a batch operator's. `sysio.msgch::bootstrap` gates on `require_auth(get_self())`, so only the holder of `sysio.msgch`'s own authority (the genesis / bootstrap process) can trigger it. `do_poll_epoch_state` was pushing `msgch::bootstrap` at epoch 0 signed with the operator's own account authority, which the chain rejects UNCONDITIONALLY with `missing authority of sysio.msgch (3090004)` before the epoch check ever runs. It never advanced anything; it only produced boot-window error-log noise (3 lines/run observed on the 9-op clusters). From epoch 1 onward `advance` re-arms itself via `evalcons` consensus; batch operators never trigger it. Remove the epoch==0 bootstrap-push block and the now-orphan `action_bootstrap` constant. Verified on top of the chain_plugin sync gate (#520): full unit sweep green (unit_test 1507/1507, contracts_unit_test, plugin_test, test_fc, and the chain / underwriter / batch_operator plugin test binaries), and the full 13-flow suite 13/13 SUCCEEDED with the `msgch::bootstrap 3090004` signature now 0 across every cluster (was 3x on the 9-op runs) and `3060002/3060003` still 0. Co-Authored-By: Claude <noreply@anthropic.com> Change-Id: I08613c5379c85ba98e5d00a1c794ac00fb9b2de5
This was referenced Jul 16, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #520
Base is
fix/chain-plugin-sync-gate(PR #520 — the chain_plugin sync gate). This PR is the one-file follow-up the sync-gate PR called out as out-of-scope. Review #520 first; GitHub will auto-retarget this tomasteronce #520 merges.Problem
batch_operator_plugin::do_poll_epoch_statepushedsysio.msgch::bootstrapat epoch 0 to trigger the genesis advance — signed with the operator's own account authority. Butmsgch::bootstrapgates onrequire_auth(get_self())(i.e.sysio.msgch's own authority), so the chain rejected the push unconditionally withmissing authority of sysio.msgch (3090004), before thecheck(epoch == 0)ever ran. It never advanced anything — it only emitted boot-window error-log noise (3 lines/run on the 9-op clusters).The genesis advance is a system responsibility: only the holder of
sysio.msgch's authority (the genesis / bootstrap process; the harness in test clusters) can trigger it. From epoch 1 onward,advancere-arms itself viaevalconsconsensus — batch operators never trigger it.Change
Remove the
epoch == 0bootstrap-push block fromdo_poll_epoch_stateand the now-orphanaction_bootstrapconstant. One file, +9/−14.Verification
On top of #520:
unit_test1507/1507,contracts_unit_test,plugin_test,test_fc, and thetest_chain_plugin/test_underwriter_plugin/test_batch_operator_pluginbinaries.msgch::bootstrap 3090004signature = 0 across all 13 clusters (was 3× on the 9-op runs of the parent branch — this is exactly what the change removes).3060002/3060003(the sync-gate target) still 0 across all 13.🤖 Generated with Claude Code