fix(sdk-core): decode accounts without created timestamps#51
Merged
Conversation
joshglogau
marked this pull request as ready for review
July 21, 2026 19:32
svetla-urt
previously approved these changes
Jul 21, 2026
bearcubsvet
approved these changes
Jul 21, 2026
bearcubsvet
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API.v1.AccountObject.createdto be omitted and expose it asTimePoint | null.get_accountdecoding for valid system-account responses with reduced metadata.Root cause
The Sandbox
sysioaccount is valid, but itsget_accountresponse omits the legacycreatedfield. The decoder treated that field as required and rejected the entire response.Impact
SDK consumers can query these system accounts normally without falling back to untyped responses. Consumers must handle
created === nullwhen an RPC omits the timestamp.Validation
pnpm --filter @wireio/sdk-core compilepnpm --filter @wireio/sdk-core typecheck:strict-nullChain.test.ts: 14 tests passedsysiowithcreated: null