Remove base_per_transaction_net_usage from blockchain_parameters#101
Merged
Merged
Conversation
The parameter no longer participates in NET billing on the chain side (replaced by a per-action overhead computed from fixed_net_overhead_of_packed_trx); wire-sysio removes it from chain_config_v0, and this struct must match that fc::raw layout field-for-field because set_blockchain_parameters_packed unpacks the packed blob directly into chain_config_v0.
huangminghuang
approved these changes
Jul 15, 2026
huangminghuang
left a comment
huangminghuang
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the complete patch and companion wire-sysio layout change. The serialized field order matches chain_config_v0, the 76-byte packed layout was verified, and local Release build/tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
base_per_transaction_net_usage(field and SYSLIB_SERIALIZE entry) fromblockchain_parameters, pairing with the wire-sysio removal of the parameter fromchain_config_v0(PR link added there). The host'sset_blockchain_parameters_packedunpacks the packed blob directly intochain_config_v0, so this struct must match its fc::raw layout field-for-field.Note
get_blockchain_parameters/set_blockchain_parametersare compiled intolibsysiofromsysiolib.cpp, so contracts must be built against a CDT rebuilt with this header; the system and test contracts committed in the wire-sysio PR were rebuilt that way.