Ship: remove base_per_transaction_net_usage from the embedded SHiP ABI#14
Merged
Merged
Conversation
wire-sysio #519 removed the field from chain_config (regenesis, new chain_id). The embedded copy must match the streamed ABI or global_property deltas misdecode whenever the embedded copy is used instead of the handshake-streamed one.
huangminghuang
approved these changes
Jul 20, 2026
huangminghuang
left a comment
huangminghuang
left a comment
Contributor
There was a problem hiding this comment.
Reviewed at 445d802. No actionable findings; the local Release build and all tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wire-sysio #519 removed
base_per_transaction_net_usagefromchain_config(part of the regenesis that produced chain_id087244f6...). This syncs the embedded SHiP ABI andship_protocol.hppstructs (bothchain_config_v0andchain_config_v1) soglobal_propertydeltas decode correctly whenever the embedded copy is used instead of the handshake-streamed ABI.