Fix build, fix stuck chat fetching, add tapback reactions - #6
Open
erik-nilcoast wants to merge 2 commits into
Open
Fix build, fix stuck chat fetching, add tapback reactions#6erik-nilcoast wants to merge 2 commits into
erik-nilcoast wants to merge 2 commits into
Conversation
- fix: drop waftools/pebble_sdk_version.py -- collides by name with a module the SDK now bundles in its own waflib/extras/, so waf's tool cache silently loads the SDK's version instead and ctx.supports_bitmap_resource() never gets defined, crashing pebble build at configure - refactor: remove the now-dead aplite_legacy.py/configure_appinfo.py bitmap->png transform and its wscript wiring -- appinfo.json has no bitmap-type resources for it to ever apply to - fix: re-enable limit/offset on chat/query -- the 2023 BlueBubbles sort-order bug the old comment referenced is fixed upstream; without it the app pulls up to 1000 chats per call and tries to build a menu the watch can't render, which is what "stuck on Fetching Chats" actually was
- feature: long-press Select opens a message-target picker, then a
Love/Like/Dislike/Laugh/Emphasize/Question picker, and sends
POST /api/v1/message/react
- feature: incoming reactions are parsed out of the message list and
shown as a suffix on the reacted-to message's timestamp
- fix: associatedMessageType is a string on the wire ("love"/"-love"),
not the numeric 2000-2005/3000-3005 IMCore storage codes
- fix: associatedMessageGuid is part-prefixed ("p:0/<guid>"), stripped
before matching against msg.guid
- refactor: extract messageDisplayName/messageBodyText out of the
render loop so the target picker can reuse the same logic
Author
|
Thanks for building this! I just started integrating some of this source into a watch face: https://apps.repebble.com/b732cafdc10a4397ace6f949 and figured I'd fix some of the upstream issues with modern hardware / bubble server fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waftools/pebble_sdk_version.pyis bundled nowlimit/offset,chat/querywas pulling up to 1000 chats per call and trying to builda menu the watch can't render.
target picker, then a Love/Like/Dislike/Laugh/Emphasize/Question
picker,.