Apply kubernetes service parameters during reconciliation#548
Merged
Conversation
DM creates kubernetes/kube_apiserver service parameters in the sysinv
database but never issues the service-parameter-apply API call. Unlike
most service parameters that are consumed by puppet classes during
host unlock, kube_apiserver parameters are only applied by the
change_k8s_control_plane_params.py script, which is exclusively
triggered via the service-parameter-apply API.
This results in the parameters being stored in the database while
kube-apiserver continues running with default settings.
Issue the service-parameter-apply for the kubernetes service when
kube_apiserver parameters are present in the deployment configuration.
Update the gophercloud dependency to fix the Apply function which
incorrectly expected HTTP 204 and attempted to decode an empty
response body.
Test Plan:
PASS: Deploy subcloud with kubernetes/kube_apiserver service
parameters (tls-min-version, tls-cipher-suites). Verify
kube-apiserver static pod manifest reflects the configured
values after deployment completes.
PASS: Deploy system without kubernetes service parameters. Verify
no apply is issued and reconciliation completes normally.
PASS: Deploy dc system controller with kubernetes service parameters
applied beforehand during bootstrap. Verify no apply is issued
and reconciliation completes normally.
Signed-off-by: Wallysson <wallysson.silva@windriver.com>
enzocandotti
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DM creates kubernetes/kube_apiserver service parameters in the sysinv database but never issues the service-parameter-apply API call. Unlike most service parameters that are consumed by puppet classes during host unlock, kube_apiserver parameters are only applied by the change_k8s_control_plane_params.py script, which is exclusively triggered via the service-parameter-apply API.
This results in the parameters being stored in the database while kube-apiserver continues running with default settings.
Issue the service-parameter-apply for the kubernetes service when kube_apiserver parameters are present in the deployment configuration. Update the gophercloud dependency to fix the Apply function which incorrectly expected HTTP 204 and attempted to decode an empty response body.
Test Plan: