Skip to content

fix: enforce managed playwright use defaults#869

Open
exKAZUu wants to merge 1 commit into
mainfrom
fix/wbfy-enforce-playwright-use-defaults
Open

fix: enforce managed playwright use defaults#869
exKAZUu wants to merge 1 commit into
mainfrom
fix/wbfy-enforce-playwright-use-defaults

Conversation

@exKAZUu

@exKAZUu exKAZUu commented Jun 11, 2026

Copy link
Copy Markdown
Member

Customer Summary

  • wbfy now updates the managed Playwright use.trace, use.screenshot, and use.video settings even when those fields already exist in playwright.config.ts.
  • Existing non-managed Playwright settings remain preserved, so local project-specific config is not broadly overwritten.

Technical Summary

  • Split default config creation from merging in packages/wbfy/src/fixers/playwrightConfig.ts.
  • Added a focused post-merge step that overwrites only the managed use artifact settings from the generated defaults.
  • Kept the existing merge behavior for other top-level and nested Playwright config fields.

Why

  • The previous recursive merge treated existing use values as local overrides, so wbfy only backfilled missing artifact settings and did not normalize stale values.
  • A targeted post-merge normalization fixes the reported behavior without making wbfy overwrite unrelated Playwright customization.

Testing

  • yarn verify
  • Pre-commit cleanup hook passed.
  • Pre-push lint hook passed.

Notes

  • No tests were added because this repository's local instructions say to write tests only when explicitly requested.

Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Playwright configuration fixer in packages/wbfy/src/fixers/playwrightConfig.ts by introducing a new helper function applyManagedUseDefaults. This function ensures that specific default settings for trace, screenshot, and video are consistently applied to the merged configuration, overriding any local adjustments. No review comments were provided, and the changes align with the repository's coding standards.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant