Task2 by ZuodongWang · Pull Request #6 · Will-Shanks/LeedsCapstone

ZuodongWang · 2019-10-25T01:41:05Z

No description provided.

pep8speaks · 2019-10-25T01:41:08Z

Hello @ZuodongWang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/draw5.py:

Line 23:1: E303 too many blank lines (3)
Line 25:35: E203 whitespace before ':'
Line 26:35: E203 whitespace before ':'
Line 27:1: W293 blank line contains whitespace
Line 32:13: E128 continuation line under-indented for visual indent
Line 33:13: E128 continuation line under-indented for visual indent
Line 34:13: E128 continuation line under-indented for visual indent
Line 35:13: E128 continuation line under-indented for visual indent
Line 35:30: W291 trailing whitespace
Line 36:13: E128 continuation line under-indented for visual indent
Line 37:9: E124 closing bracket does not match visual indentation
Line 41:1: W293 blank line contains whitespace
Line 42:80: E501 line too long (94 > 79 characters)
Line 47:5: E303 too many blank lines (2)
Line 49:1: E302 expected 2 blank lines, found 1
Line 60:10: E225 missing whitespace around operator
Line 67:10: E225 missing whitespace around operator
Line 68:1: W293 blank line contains whitespace
Line 75:1: E302 expected 2 blank lines, found 1
Line 85:10: E225 missing whitespace around operator
Line 92:10: E225 missing whitespace around operator
Line 93:1: W293 blank line contains whitespace
Line 99:1: W293 blank line contains whitespace
Line 100:1: E302 expected 2 blank lines, found 1
Line 110:1: W293 blank line contains whitespace
Line 117:1: W293 blank line contains whitespace
Line 126:5: E303 too many blank lines (2)
Line 126:80: E501 line too long (85 > 79 characters)
Line 127:80: E501 line too long (84 > 79 characters)
Line 127:85: W291 trailing whitespace
Line 148:1: W293 blank line contains whitespace
Line 149:80: E501 line too long (93 > 79 characters)
Line 159:80: E501 line too long (87 > 79 characters)
Line 165:5: E303 too many blank lines (2)
Line 170:80: E501 line too long (89 > 79 characters)
Line 181:80: E501 line too long (85 > 79 characters)
Line 182:1: W293 blank line contains whitespace
Line 184:5: E303 too many blank lines (2)
Line 189:1: E303 too many blank lines (4)
Line 190:1: W293 blank line contains whitespace
Line 194:5: E303 too many blank lines (2)
Line 195:80: E501 line too long (94 > 79 characters)
Line 202:9: E303 too many blank lines (2)
Line 206:9: E303 too many blank lines (2)
Line 219:5: E265 block comment should start with '# '
Line 220:5: E731 do not assign a lambda expression, use a def
Line 224:80: E501 line too long (120 > 79 characters)
Line 224:96: E261 at least two spaces before inline comment
Line 224:96: E262 inline comment should start with '# '
Line 228:1: E303 too many blank lines (3)
Line 231:80: E501 line too long (142 > 79 characters)
Line 231:119: E261 at least two spaces before inline comment
Line 231:119: E262 inline comment should start with '# '
Line 236:1: W293 blank line contains whitespace
Line 245:1: E303 too many blank lines (3)
Line 248:34: E231 missing whitespace after ','
Line 249:1: W391 blank line at end of file

Comment last updated at 2020-02-25 03:25:14 UTC

task 2b draft

Will-Shanks · 2019-11-03T21:40:07Z

resolves #2 (linking this PR w/ issue)

This code could be cleaned up A LOT, but all the functionality is there. It ignores the 1 bottom and 1 top percent of word heights

JadeWibbels

Hi guys! As promised I am going to be adding code review requests. The files in task2 seem to have a LOT of overlap on functionality. Making things more modular would mean that there is less duplication of code/effort. We also need unit tests!
I would be happy to meet with you in small groups or one on one if you have questions on any comments. Also! If you think that things are perfect the way they are feel free to reply to my comments and explain the whys!

JadeWibbels · 2020-01-16T00:36:30Z

+
+logging.basicConfig(level=logging.INFO)
+
+def getColumnDelimiters(fName):


There is some good documentation here, but could use more parameter information. There are also some opportunities for splitting out smaller functions to increase modularity.

JadeWibbels · 2020-01-16T00:37:17Z

+    return columnSeperatorXVals
+
+
+def main():


Similar comments on encouraging modularity.

JadeWibbels · 2020-01-16T00:37:29Z

+
+
+if __name__ == "__main__":
+    main()


Unit tests please!

JadeWibbels · 2020-01-16T00:42:33Z

@@ -0,0 +1,133 @@
+#!/usr/bin/env python3


This file looks like it contains a lot of the same functionality as the previous file. If you find you are re writing and re using the same code in multiple areas, I would recommend splitting it out and making it more modular.

JadeWibbels · 2020-01-16T00:42:46Z

+
+
+if __name__ == "__main__":
+    main()


Unit tests please!

moved commit to branch "3col" This reverts commit fef4e89.

Creates unified day files. Currently this runs insanely slow on summit. Although the current version has not been run yet and is much simpler. The 4 lines of code do run pretty fast on a local machine.

Will-Shanks

It would be helpful if comments were added to the code to make it more readable.
Could you please also change the filenames to better reflect what they do. Since we have multiple job submission scripts it would be helpful to denote what this job in particular does in the submit script name, same goes for the draw5.py filename.

kevmonsta · 2020-04-01T14:49:29Z

I am not fully sure what this code does.

It looks like we need Zoudong to add some comments to the code and I would also like to request that we get a description of what this code does.

Will-Shanks · 2020-04-01T16:24:15Z

I am not fully sure what this code does.

It looks like we need Zoudong to add some comments to the code and I would also like to request that we get a description of what this code does.

I believe this is actually the branch Remy has been working on not Zoudong, so it probably makes more sense to have him write a description of what it does.

reda2367 and others added 3 commits October 23, 2019 02:21

Add files via upload

d268679

Styled_code

d86a1c2

Update draw2_styled.py

198518c

task 2b draft

12940e0

task 2b draft

reda2367 and others added 3 commits November 12, 2019 18:37

Add files via upload

a8eeff6

This code could be cleaned up A LOT, but all the functionality is there. It ignores the 1 bottom and 1 top percent of word heights

Delete the draft of task2_problem2

625e09a

Add files via upload

59a5f9b

JadeWibbels suggested changes Jan 16, 2020

View reviewed changes

Will-Shanks linked an issue Feb 11, 2020 that may be closed by this pull request

task2 #2

Open

reda2367 and others added 7 commits February 14, 2020 14:14

Add files via upload

d76a11d

Removed old tasks dir

2a55ff1

moved draw5

4a75591

Add files via upload

5fdc9f2

moved draw5

3f43f5a

Three column page

fef4e89

Revert "Three column page"

f399541

moved commit to branch "3col" This reverts commit fef4e89.

kevmonsta linked an issue Feb 25, 2020 that may be closed by this pull request

Create Unified Day Files #26

Open

Script to run draw5.py on summit.

d7d2dbb

Creates unified day files. Currently this runs insanely slow on summit. Although the current version has not been run yet and is much simpler. The 4 lines of code do run pretty fast on a local machine.

Will-Shanks assigned reda2367 and kevmonsta Feb 25, 2020

Will-Shanks suggested changes Feb 25, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Task2#6

Task2#6
ZuodongWang wants to merge 15 commits into
masterfrom
task2

ZuodongWang commented Oct 25, 2019

Uh oh!

pep8speaks commented Oct 25, 2019 •

edited

Loading

Uh oh!

Will-Shanks commented Nov 3, 2019

Uh oh!

JadeWibbels left a comment

Uh oh!

JadeWibbels Jan 16, 2020

Uh oh!

JadeWibbels Jan 16, 2020

Uh oh!

JadeWibbels Jan 16, 2020

Uh oh!

JadeWibbels Jan 16, 2020

Uh oh!

JadeWibbels Jan 16, 2020

Uh oh!

Will-Shanks left a comment

Uh oh!

kevmonsta commented Apr 1, 2020

Uh oh!

Will-Shanks commented Apr 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants


		logging.basicConfig(level=logging.INFO)

		def getColumnDelimiters(fName):

Conversation

ZuodongWang commented Oct 25, 2019

Uh oh!

pep8speaks commented Oct 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2020-02-25 03:25:14 UTC

Uh oh!

Will-Shanks commented Nov 3, 2019

Uh oh!

JadeWibbels left a comment

Choose a reason for hiding this comment

Uh oh!

JadeWibbels Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

JadeWibbels Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

JadeWibbels Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

JadeWibbels Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

JadeWibbels Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

Will-Shanks left a comment

Choose a reason for hiding this comment

Uh oh!

kevmonsta commented Apr 1, 2020

Uh oh!

Will-Shanks commented Apr 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

pep8speaks commented Oct 25, 2019 •

edited

Loading