Add IL comparison path copy buttons to HTML reports - #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ILMatch/ILMismatchlabel whenShouldOutputILText=truediff_report.htmland copy a platform-appropriate quoted path pair for WinMerge,diff, and other text-based diff tools:focus-visible, while preserving keyboard-focus behaviorRoot cause
The shared tooltip rule used
.btn-tooltip-wrap:focus-within, so clicking a copy button left focus inside the wrapper and kept the tooltip visible even after hover ended. The rule now targets the actual buttons with:focus-visible, which keeps keyboard accessibility without pinning the tooltip after pointer clicks.Testing
npm run test:js -- --runInBand— 175 passed at the current headdotnet test FolderDiffIL4DotNet.Tests/FolderDiffIL4DotNet.Tests.csproj -c Release --no-restore --disable-build-servers -m:1 --filter FullyQualifiedName~HtmlReport --nologo— 240 passed at the current headenv GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=false dotnet test FolderDiffIL4DotNet.Tests/FolderDiffIL4DotNet.Tests.csproj -c Release --no-restore --disable-build-servers -m:1 --nologo— 2016 passed, 1 skipped at the current headgit diff --check— cleanNotes
file://navigation, so visual verification was limited to the supplied screenshots plus script/DOM/CSS validation.dotnet format --verify-no-changescommand still reports existing whitespace differences in unrelated source regions; this change does not rewrite those files.