Fix inherited batch database provenance - #5111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The batch parent shared only a thread-local reader. Child option, envelope, and status code could therefore re-resolve database, project, and Git metadata from the current working directory and mix two repositories in one response.
Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false(0 warnings, 0 errors)dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build -p:UseSharedCompilation=false --filter FullyQualifiedName~CodeIndex.Tests.QueryCommandRunnerTests.RunBatch(45/45 on net8.0 and net9.0)dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build -p:UseSharedCompilation=false --filter FullyQualifiedName~Issue5083(4/4 on net8.0 and net9.0)dotnet run --project tools/CodeIndex.Changelog -- checkcdidx status --checkandcdidx workspace status --checkDocumentation and changelog
DEVELOPER_GUIDE.mdTESTING_GUIDE.mdchangelog.d/unreleased/5083.fixed.mdFollow-up candidates
Fixes #5083