Bound large database comparisons and structure JSON failures - #5064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import --check --jsonbudget failures and actionable human diagnostics.Root cause
Large identical databases always entered the bounded streaming row comparison, so an identical input could exhaust the one-million-row safety budget. The import boundary also treated comparison-budget exhaustion as an unclassified failure. Filesystem identity alone was insufficient for aliases because immutable-mode and path-specific SQLite sidecars can expose different snapshots.
Validation
Base
This branch is intentionally based on
d444cfdb2c660425afda504b9998977cdf15c89e. Newerorigin/maincommits were not incorporated per maintainer instruction.Documentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.md.changelog.d/unreleased/5052.fixed.md.Follow-up
Fixes #5052