Accept negative-score search cursors as option values - #4699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--cursorvalues-qfrom being consumed as cursor dataorigin/mainthroughb72ebf595Root cause
Issue #4664: the shared string-option reader rejected every separated value beginning with
-. Recipe search scores are commonly negative, so replay commands generated fromnext_cursorwere interpreted as a missing--cursorvalue followed by an unsupported option.Issue #4705: the Windows
net8.0lane reached the repository-wide 3,600,000 ms test-session timeout with 9,347 passed, 0 failed, and 3 skipped tests. Restore and build took about 90 seconds, leaving sufficient room under the 90-minute job timeout for a bounded 75-minute test session.Impact
Generated recipe/audit pagination commands can replay negative-score cursors unchanged and return the next result page. Other dash-prefixed tokens retain their prior option-parsing behavior. The Windows CI suite remains bounded but is no longer aborted exactly at 60 minutes before completing.
Validation
dotnet restore CodeIndex.sln --locked-modeCiWorkflowTests: 12 passed on net8.0QueryCommandRunnerTests: 1,539 passed and 1 documented platform-specific test skipped on net8.0 before the final no-conflict main mergemake lintdotnet run --project tools/CodeIndex.Changelog --no-restore -- check(98 fragments)No blocking/actionable issues found.Documentation and changelog
README.mdTESTING_GUIDE.mdchangelog.d/unreleased/4664.fixed.mdchangelog.d/unreleased/4705.internal.mdFixes #4664
Fixes #4705