Apply deps filters before graph materialization - #4696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
depsexact-symbol, symbol-family, and noise filters into SQLite before graph materialization, ranking, and display limits.--symbol/--symbol-familyinput cardinality before opening SQLite.Root cause
RunDepsmaterialized and ranked broad dependency candidates before applying symbol and noise filters. Consequently,--limit 1still processed the repository-wide graph, and SQL pushdown also needed explicit safeguards for SQLite expression depth.Validation
deps --symbol TryReadUtf8File --limit 1 --json --no-progress): completed in 2.27 seconds (Issue report: 10m37s).net8.0: 9,716 passed, 6 skipped, 0 failed.net9.0: 9,250 passed, 411 skipped, 0 failed.net8.0: 91 passed, 0 failed.net9.0: 90 passed, 1 skipped, 0 failed.dotnet format CodeIndex.sln --verify-no-changes --no-restore.Adversarial review
Documentation and changelog
changelog.d/unreleased/4619.fixed.md.Follow-up candidates
Fixes #4619