Fix PostgreSQL extraction and index completeness contracts - #4692
Merged
Conversation
…20-final2 # Conflicts: # src/CodeIndex/Mcp/McpToolHandlers.Indexing.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RETURNS TABLE (...)signatures with quote-aware balanced delimiters so defaults and quoted identifiers do not truncate returned columns;--allow-partial, and recover unresolved failures through a normal full scan without requiring--rebuild;Validation
dotnet restore CodeIndex.sln --disable-paralleldotnet build CodeIndex.sln -c Release --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=false(0 warnings, 0 errors)dotnet test CodeIndex.sln -c Release --no-restore --no-build --disable-build-servers -p:UseSharedCompilation=false(net8: 9,718 passed / 6 skipped; net9: 9,252 passed / 410 skipped; three unrelated parallel-isolation/timing failures all passed when rerun alone)make lintdotnet run --project tools/CodeIndex.Changelog -- checkcdidx index . --jsonandstatus --check --json(1,013 files, 0 errors, all readiness signals true, workspace matched)Review
Two Codex adversarial-review rounds were completed. All actionable findings were addressed: scoped partial-index recovery, unavailable-cap-state guidance, mode-specific
--allow-partialhelp, and state-specific status repair/explanation text.Documentation and changelog
AGENT_GUIDE.mdfor the new contracts.changelog.d/unreleased/4609.fixed.md,changelog.d/unreleased/4610.fixed.md, andchangelog.d/unreleased/4620.fixed.md.AGENTS.mdandCLAUDE.mdwere not changed.Follow-up candidates
None.
Fixes #4609
Fixes #4610
Fixes #4620