Classify Python type declarations with semantic kinds - #4690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeAlias/NewTypedeclarations astypealias.TypeVar/ParamSpec/TypeVarTupledeclarations astype_parameter, register both kinds across schema, query hints, and completions, and expose theirtypecompatibility family.Root cause
The Python symbol extractor classified local type declarations with the
importkind. The public kind catalog did not contain a dedicated type-parameter kind, and unchanged Python files would otherwise retain the old persisted classification after an upgrade.Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false— passed with 0 warnings and 0 errors.dotnet run --project tools/CodeIndex.Changelog -- check— validated all 79 fragments.dotnet format CodeIndex.sln --verify-no-changes --no-restore— passed.No blocking/actionable issues found.Follow-up candidates
Fixes #4615