fix: preserve custom encoding row cache boundaries - #2846
Merged
WerWolv merged 2 commits intoAug 16, 2026
Conversation
Closed
1 task
WerWolv
requested changes
Aug 16, 2026
Owner
|
Simply for transparency sake, this entire PR and interaction feels extremely like I'm talking to an LLM. |
Contributor
Author
|
Hi @WerWolv , I did use AI for review/and quick fix to your comment using a review bot. But initial code change/and submissions were done by me. |
Owner
|
Thank you! |
Contributor
Author
|
sorry for trouble, thank you for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Fixes #2805. The custom encoding view could use continuation offsets written by earlier repaint passes at the wrong row index, causing scroll-dependent decoding errors around row boundaries for multi-byte encodings.
Implementation description
Store a computed continuation only when rendering the current cache tail. The cache therefore keeps one decode-start offset per file row instead of appending stale offsets on every repaint. Adds a focused
EncodingLineStartAddressCachehelpers test that covers both already-cached rows and tail extension.Screenshots
Not applicable; this corrects decoding state rather than layout.
Additional things
The PR adds focused regression coverage for the cache-tail behavior.