Add CodingTransformer map helpers#29
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends CodingTransformer with convenient map helpers to enable lightweight output projections and common optional/default mapping pipelines, and documents the pattern for derived properties.
Changes:
- Add
CodingTransformer.map(_:)to map successful outputs while propagating upstream failures and mapping-thrown errors. - Add
map(defaultValue:_:)andmap(defaultValue:fallbackValue:_:)to streamline optional-output pipelines (default-before-map and failable-map-with-fallback). - Add targeted tests for success/failure propagation and optional/fallback behaviors, plus README documentation for the derived-key usage pattern.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/CodableKit/Transformers/CodingTransformer.swift | Adds the public map helper overloads on CodingTransformer. |
| Sources/CodableKit/Transformers/CodingTransformerComposition.swift | Introduces MapTransformer implementation used by map(_:) and removes redundant explicit initializers (memberwise inits suffice). |
| Tests/TransformerTests/DerivedValueTransformerTests.swift | Adds test coverage for mapping success, upstream failure propagation, thrown mapping failures, and optional/fallback variants. |
| README.md | Documents the new .map helpers with a concise derived-property example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodingTransformer.map(_:)for lightweight output projections.Tests
swift format lint --strict Sources/CodableKit/Transformers/CodingTransformer.swift Sources/CodableKit/Transformers/CodingTransformerComposition.swift Tests/TransformerTests/DerivedValueTransformerTests.swiftgit diff --checkswift test --filter DerivedValueTransformerTestsswift test