Fixed aggregation for dActionWhen conditions - #352
Open
podcherklife wants to merge 1 commit into
Open
Conversation
Member
|
TP2-when folds with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So grammar allows specifying a list of conditions for some d actions, but as of now values are not properly folded, the last condition always wins.
This is obviously an oversight, but this fix is kind of questionable. Like, should should conditions be combined with
||or with&&?&&seems more intuitive, but||seems more useful. Does it even make sense at all, why would anybody want to have two separate conditions instead of combining them into a single regex? I've searched through a quite extensive(but not exhaustive) list of .d files and none was using more than 1 condition.Questions, questions...
Nevertheless, something should be dome about this, even if just adding a warning about dead conditions.