Skip to content

Remove EXPERIMENTAL from --list-components-json - #239

Merged
FredrikLindgren merged 1 commit into
WeiDUorg:develfrom
ALIENQuake:patch-1
Mar 29, 2026
Merged

Remove EXPERIMENTAL from --list-components-json#239
FredrikLindgren merged 1 commit into
WeiDUorg:develfrom
ALIENQuake:patch-1

Conversation

@ALIENQuake

@ALIENQuake ALIENQuake commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Given it's been used for 5+ years and there was only a single bugfix, it's hardly considered experimental.

Context: People are scared of using --list-components-json (and thus LABELS since it's the only way to get them) because of the 'experimental' flag.

@FredrikLindgren

Copy link
Copy Markdown
Member

I added 'experimental' because I was not prepared to guarantee that the structure of the output would be stable into the future. Now, I guess, it's largely an academic concern, since I've basically given up on the use case for the feature, since there is too much about WeiDU that either outright assumes and relies on an interactive session, or which can only be accurately evaluated in the context of a running WeiDU instance.

@mleduque

mleduque commented Jan 1, 2026

Copy link
Copy Markdown

Oh that's sad...
I'm actually using this in my own project https://github.com/mleduque/modda

edit : sorry, I misunderstood this PR as removing the feature (and not the experimental flag)

@FredrikLindgren

Copy link
Copy Markdown
Member

I probably just need to accept that this is maybe useful to people the way it is now and the window for calling it experimental and maybe making breaking changes to how it works has passed.

@suy

suy commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

I think the feature is useful to some, but those who find it useful are likely to accept breaking changes if it's for the better. I have been using Zeitgeist lately for some installs, and the feature is useful enough for me despite its limits. But if there are improvements in the future, I would not mind fixing Zeitgeist myself to adapt to any changes.

Alternatively, a new command line switch might be added with a different output, if you don't mind supporting both.

I think the only application that relies on this and which is closed source (and now unmantained) is Project Infinity.

Copilot AI review requested due to automatic review settings March 28, 2026 09:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the “EXPERIMENTAL” wording from the --list-components-json CLI help text to reflect its long-standing stability and encourage usage.

Changes:

  • Updates the --list-components-json usage string to drop “EXPERIMENTAL!”.
  • Adjusts the --save-components-name help text (but introduces a log filename casing inconsistency).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main.ml Outdated
@ALIENQuake

Copy link
Copy Markdown
Contributor Author

@FredrikLindgren This feature is foundation of Project Infinity. You can safely seal it. Providing additional features that make an impact (which I requested on weidu boards) can be implemented using new command-line options.

In the meantime, please accept this PR, it shouldn't be a big deal.

@FredrikLindgren

Copy link
Copy Markdown
Member

I'm not merging this branch in its current state: two merge commits when there should be zero, and apparently all for adding a commit that has nothing to do with the PR. Additionally, the added commit has a nearly information-free description, and expanding it somehow reduces the information content further, which is not how these things are supposed to work. No points for having the stochastic parrot pipe up.

I could be persuaded to cherry-pick the initial commit, but what I'd need to see to merge this is:

  • Redoing it to use rebase instead of merge (you can then force-push the "new" commit to update the PR)
  • Either no second commit or, at least, a useful description.

@ALIENQuake

Copy link
Copy Markdown
Contributor Author

@FredrikLindgren Done.

@FredrikLindgren

Copy link
Copy Markdown
Member

Thanks. Merged and I'll push at the end of the day.

@FredrikLindgren
FredrikLindgren merged commit 2c43448 into WeiDUorg:devel Mar 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants