Remove EXPERIMENTAL from --list-components-json - #239
Conversation
|
I added 'experimental' because I was not prepared to guarantee that the structure of the output would be stable into the future. Now, I guess, it's largely an academic concern, since I've basically given up on the use case for the feature, since there is too much about WeiDU that either outright assumes and relies on an interactive session, or which can only be accurately evaluated in the context of a running WeiDU instance. |
|
Oh that's sad... edit : sorry, I misunderstood this PR as removing the feature (and not the experimental flag) |
|
I probably just need to accept that this is maybe useful to people the way it is now and the window for calling it experimental and maybe making breaking changes to how it works has passed. |
|
I think the feature is useful to some, but those who find it useful are likely to accept breaking changes if it's for the better. I have been using Zeitgeist lately for some installs, and the feature is useful enough for me despite its limits. But if there are improvements in the future, I would not mind fixing Zeitgeist myself to adapt to any changes. Alternatively, a new command line switch might be added with a different output, if you don't mind supporting both. I think the only application that relies on this and which is closed source (and now unmantained) is Project Infinity. |
There was a problem hiding this comment.
Pull request overview
Removes the “EXPERIMENTAL” wording from the --list-components-json CLI help text to reflect its long-standing stability and encourage usage.
Changes:
- Updates the
--list-components-jsonusage string to drop “EXPERIMENTAL!”. - Adjusts the
--save-components-namehelp text (but introduces a log filename casing inconsistency).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@FredrikLindgren This feature is foundation of Project Infinity. You can safely seal it. Providing additional features that make an impact (which I requested on weidu boards) can be implemented using new command-line options. In the meantime, please accept this PR, it shouldn't be a big deal. |
|
I'm not merging this branch in its current state: two merge commits when there should be zero, and apparently all for adding a commit that has nothing to do with the PR. Additionally, the added commit has a nearly information-free description, and expanding it somehow reduces the information content further, which is not how these things are supposed to work. No points for having the stochastic parrot pipe up. I could be persuaded to cherry-pick the initial commit, but what I'd need to see to merge this is:
|
|
@FredrikLindgren Done. |
|
Thanks. Merged and I'll push at the end of the day. |
Given it's been used for 5+ years and there was only a single bugfix, it's hardly considered experimental.
Context: People are scared of using
--list-components-json(and thus LABELS since it's the only way to get them) because of the 'experimental' flag.