feat(database): optional DB connection + db-manager provisioning#9
Draft
solovyovk wants to merge 1 commit into
Draft
feat(database): optional DB connection + db-manager provisioning#9solovyovk wants to merge 1 commit into
solovyovk wants to merge 1 commit into
Conversation
Add two independent, opt-in concerns to the WProofreader chart: - database: connection config for the database service provider. When database.enabled, injects WPR_ENABLE_DATABASE_PROVIDER + WPR_DATABASE_* env into the AppServer (read directly at startup since WProofreader v6.0.0). - databaseProvisioning: provision that database with db-manager (schema, migrations, appserver/app_manager users + grants) via a pre-install/ pre-upgrade hook Job that runs before the AppServer pods start. Details: - One shared credentials Secret (pre-install hook when provisioning) or database.existingSecret; required-field guards for passwords. - db-manager image tag defaults to the chart appVersion so it always carries the matching per-version schema migrations. - The MySQL server itself is not managed here; database.host points at an existing MySQL. Feature is fully inert when both toggles are false. - Ship default contexts=external,seed (client). - Add manifests/db-credentials-secret.yaml example. - Bump chart to 1.4.0, appVersion to 6.13.1.0.
solovyovk
force-pushed
the
db-manager-provisioning
branch
from
8fdf5c1 to
5d313f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: D0-359 — Extend wproofreader-helm with db-manager integration. Related: D0-358.
What this adds
Two independent, opt-in concerns on the WProofreader chart (both fully inert when their toggles are false):
database— connection config for the DB service provider. Whendatabase.enabled, injectsWPR_ENABLE_DATABASE_PROVIDER+WPR_DATABASE_*env into the AppServer (read directly at startup since WProofreader v6.0.0).databaseProvisioning— provisions that database with db-manager (schema, migrations,appserver/app_managerusers + grants) via a pre-install/pre-upgrade hook Job that runs before the AppServer pods start.Details
database.existingSecret; required-field guards for passwords.appVersion, so it always carries the matching per-version schema migrations.database.hostpoints at an existing MySQL.contexts=external,seed(client);values-dev.yamlusesinternal,seed(the WSC-internal SID hierarchy app-manager needs).manifests/db-credentials-secret.yamlexample +values-dev.yaml(excluded from the packaged chart via.helmignore).Verification
Deployed end-to-end on minikube via ArgoCD:
cloud_serviceprovisioned (Liquibase, contextsinternal,seed), AppServer healthy & licensed, app-manager signup FK satisfied.