Skip to content

Fix sed commands in create_release.yml#8837

Merged
sbc100 merged 3 commits into
mainfrom
fix_releases
Jun 12, 2026
Merged

Fix sed commands in create_release.yml#8837
sbc100 merged 3 commits into
mainfrom
fix_releases

Conversation

@sbc100

@sbc100 sbc100 commented Jun 12, 2026

Copy link
Copy Markdown
Member

I broke this with #8721. This change makes it harder to break going forward.

I broke this with #8721. This change makes it harder to break
going forward.
@sbc100 sbc100 requested a review from a team as a code owner June 12, 2026 20:20
@sbc100 sbc100 requested review from kripken and stevenfontanella and removed request for a team June 12, 2026 20:20
@bashor

bashor commented Jun 12, 2026

Copy link
Copy Markdown

Could anyone please then add the "missed" artifact into 130 release or make a new release?

@sbc100

sbc100 commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Yes, it should be easy to rename the wronly-names file in the 130 release.

@kripken can you take care of that?

@sbc100 sbc100 enabled auto-merge (squash) June 12, 2026 20:40

@kripken kripken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Comment thread .github/workflows/create_release.yml Outdated
Comment thread .github/workflows/create_release.yml Outdated
@kripken

kripken commented Jun 12, 2026

Copy link
Copy Markdown
Member

I renamed them in the release.

sbc100 and others added 2 commits June 12, 2026 16:05
Co-authored-by: Alon Zakai <azakai@google.com>
Co-authored-by: Alon Zakai <azakai@google.com>
@sbc100 sbc100 disabled auto-merge June 12, 2026 23:06
@sbc100 sbc100 merged commit 8b4abbe into main Jun 12, 2026
16 checks passed
@sbc100 sbc100 deleted the fix_releases branch June 12, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants