Millie stagetimer mock - #127
Draft
gumillie222 wants to merge 7 commits into
Draft
Conversation
deliberation-researcher-portal
|
||||||||||||||||||||||||||||
| Project |
deliberation-researcher-portal
|
| Branch Review |
millie-stagetimer-mock
|
| Run status |
|
| Run duration | 05m 11s |
| Commit |
|
| Committer | gumillie222 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
23
|
| View all changes introduced in this branch ↗︎ | |
Contributor
|
Merged locally, and found some discrepancies in behavior. For example, timer would automatically click up once each second, which is not the intended behavior. Additionally, when I merged conflicts, the feature that only renders something when displayTime is achieved (e.g. if displayTime is 150 it would mean that element only appears at 150) didn't seem to function anymore. Marking as draft, so that we can return to it. |
shapeseas
marked this pull request as draft
May 14, 2025 15:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62, but still needs to add test