fix(tts): reduce Matcha mobile memory reservation - #90
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The official sherpa-onnx v1.13.2 WASM declares an 8192-page (512 MB) minimum shared memory. Together with the 149 MB data package and model initialization this can terminate Android browser workers after a successful download. Merely changing the JavaScript memory option fails because the WASM import itself requires 8192 pages.
Validation
npm run verify— 41 files / 356 tests passed; public, security, static, build and artifact checks passedRelease impact
production-impactdocs/releases/1.3.12/CONFIGURATION_IMPACT.json