fix(studio): adapt Composer across Codex 26.715 builds - #6
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d765f86525
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const overflowY = nativeOverflow.has(node) | ||
| ? nativeOverflow.get(node) | ||
| : readStyle(node).overflowY; | ||
| if (/^(auto|scroll)$/.test(overflowY)) roles.set(node, "lane"); |
There was a problem hiding this comment.
For a three-layer Composer where the intermediate lane is already visible or has been clipped with hidden/clip by a skin rule, this condition never assigns the lane role because it only matches auto|scroll. That leaves data-cts-composer-overflow="lane" absent, so audited 26.715.31251 scrolling layouts can fail lanePolicyValid, and hidden/clip lanes are not reset to visible by the hardening CSS. Mark the intermediate ancestors, or at least non-visible ones, as lanes once an editor scroll root is found.
Useful? React with 👍 / 👎.
1 participant
Summary
Root cause
Codex 26.715.31925 can omit the intermediate Composer lane and both audited builds can reuse the same nodes while switching between single-line and multiline layouts. The previous validation assumed one fixed hierarchy, while theme-local overflow rules could also make the decorated shell scroll. PR comment cards also reuse the surface class and could be mistaken for the primary Composer.
Validation
npm run check --prefix studionpm test --prefix studio(28 passed)codex review --base origin/main(no reproducible functional defects found)