Skip to content

fix(themes): cover Windows application menu - #5

Merged
Wangnov merged 6 commits into
mainfrom
agent/windows-menu-skin
Jul 18, 2026
Merged

fix(themes): cover Windows application menu#5
Wangnov merged 6 commits into
mainfrom
agent/windows-menu-skin

Conversation

@Wangnov

@Wangnov Wangnov commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • extend Windows Codex skin backgrounds behind the application menu bar
  • preserve content geometry by moving the structurally verified menu out of flex flow and applying equivalent dynamic top padding
  • derive menu foreground colors from the sidebar/main region beneath each control
  • include the renderer runtime in the payload fingerprint so runtime-only compatibility fixes re-inject
  • remove and verify all Windows menu markers during cleanup

Root cause

Codex 26.715+ renders File/Edit/View/Help as a separate DOM flex row above the sidebar/main surfaces. Existing skins theme those surfaces but not that sibling row, leaving the stock canvas visible across the top of every Windows skin.

Safety

The compatibility path activates only when the expected menu, direct sidebar, and direct main structure all match. Cleanup restores the original flow and removes every runtime-owned marker and variable.

Companion Manager PR: Wangnov/Codex-App-Manager#222

Validation

  • node --check studio/src/runtime/theme-runtime.js
  • npm run check
  • live reversible layout prototype against Windows Codex 26.715
  • confirmed the menu class remains present in Codex 26.715.3651

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e70f5775b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread studio/src/runtime/theme-runtime.js Outdated

Wangnov commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: e3ee1c96cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Wangnov commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1fca2993b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread studio/src/runtime/theme-runtime.js Outdated

Wangnov commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74d3ffe216

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread studio/src/runtime/theme-runtime.js

Wangnov commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 92d3391250

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Wangnov
Wangnov merged commit 6bf3256 into main Jul 18, 2026
2 checks passed
@Wangnov
Wangnov deleted the agent/windows-menu-skin branch July 18, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant