[mcp] fix: release stop-all sessions concurrently - #78
Conversation
|
Warning Review limit reached
More reviews will be available in 2 minutes and 12 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request implements concurrent session release during stop-all operations in KeepGPUServer by spawning independent worker threads for each session, while preserving deterministic snapshot ordering for aggregated results. It also updates relevant documentation and adds robust test coverage. The review feedback suggests increasing the thread synchronization timeouts from 0.2 to 2.0 seconds in the new tests to prevent potential flakiness on slower CI/CD runners.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Verification
PYTHONPATH=$PWD/src pytest tests/mcp/test_server.py tests/mcp/test_http_api.py -q-> 32 passedPYTHONPATH=$PWD/src pytest tests -q-> 101 passed, 12 skippedPYTHONPATH=$PWD/src mkdocs build-> built successfully with existing Material/MkDocs and unnav'd docs noticespre-commit run --all-files-> passedgit diff --check-> passedNotes
stop_keep(job_id)remains intentionally out of scope for this branch.