Skip to content

[mcp] fix: release stop-all sessions concurrently - #78

Merged
Wangmerlyn merged 3 commits into
mainfrom
codex/fix-stop-all-release-concurrency
Jun 27, 2026
Merged

[mcp] fix: release stop-all sessions concurrently#78
Wangmerlyn merged 3 commits into
mainfrom
codex/fix-stop-all-release-concurrency

Conversation

@Wangmerlyn

Copy link
Copy Markdown
Owner

Summary

  • release independent stop-all MCP sessions concurrently after taking the locked session snapshot
  • keep targeted stop behavior unchanged and aggregate stop-all results in deterministic snapshot order
  • document the stop-all concurrency contract in AGENTS.md, README, CLI/MCP docs, architecture notes, and the branch plan

Verification

  • PYTHONPATH=$PWD/src pytest tests/mcp/test_server.py tests/mcp/test_http_api.py -q -> 32 passed
  • PYTHONPATH=$PWD/src pytest tests -q -> 101 passed, 12 skipped
  • PYTHONPATH=$PWD/src mkdocs build -> built successfully with existing Material/MkDocs and unnav'd docs notices
  • pre-commit run --all-files -> passed
  • git diff --check -> passed

Notes

  • stop_keep(job_id) remains intentionally out of scope for this branch.
  • Already-stopping sessions are still reported as timed out and do not receive duplicate release work.
  • Local subagent review will be run before merge, per repo workflow.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wangmerlyn, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 12 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: db702c48-949e-4d89-92ee-a20ccb4167e9

📥 Commits

Reviewing files that changed from the base of the PR and between d71eb0b and c587f2e.

📒 Files selected for processing (8)
  • AGENTS.md
  • README.md
  • docs/concepts/architecture.md
  • docs/guides/mcp.md
  • docs/plans/stop-all-release-concurrency.md
  • docs/reference/cli.md
  • src/keep_gpu/mcp/server.py
  • tests/mcp/test_server.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-stop-all-release-concurrency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements concurrent session release during stop-all operations in KeepGPUServer by spawning independent worker threads for each session, while preserving deterministic snapshot ordering for aggregated results. It also updates relevant documentation and adds robust test coverage. The review feedback suggests increasing the thread synchronization timeouts from 0.2 to 2.0 seconds in the new tests to prevent potential flakiness on slower CI/CD runners.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/mcp/test_server.py Outdated
Comment thread tests/mcp/test_server.py Outdated
@Wangmerlyn
Wangmerlyn merged commit 4e78819 into main Jun 27, 2026
5 checks passed
@Wangmerlyn
Wangmerlyn deleted the codex/fix-stop-all-release-concurrency branch June 27, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant