Skip to content

[cuda, cli] feat: add NVML monitor and optimize cli - #47

Merged
Wangmerlyn merged 8 commits into
mainfrom
nvml-monitor
Nov 12, 2025
Merged

[cuda, cli] feat: add NVML monitor and optimize cli#47
Wangmerlyn merged 8 commits into
mainfrom
nvml-monitor

Conversation

@Wangmerlyn

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Wangmerlyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the GPU monitoring capabilities by transitioning from unreliable nvidia-smi command parsing to a direct NVML interface via the nvidia-ml-py library. This change provides a more stable and efficient way to query GPU utilization. Concurrently, the command-line interface has been optimized for clarity and user experience, introducing specific flags for utilization thresholds while maintaining backward compatibility for existing scripts that use the older, more ambiguous --threshold flag. These updates improve both the reliability of GPU state detection and the usability of the keep-gpu tool.

Highlights

  • NVML Integration: Replaced nvidia-smi parsing with direct NVML (NVIDIA Management Library) integration for more robust GPU utilization monitoring.
  • CLI Refinement: Introduced explicit --busy-threshold and --util-threshold flags for GPU utilization, deprecating the generic --threshold flag.
  • Backward Compatibility: Ensured that the legacy --threshold flag still functions, intelligently parsing its value as either a VRAM amount or a busy threshold.
  • New Module: Added a dedicated gpu_monitor utility module to encapsulate NVML interactions, including initialization, shutdown, and error handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great improvement, replacing the fragile nvidia-smi subprocess call with a robust, thread-safe NVML monitor using nvidia-ml-py. The new NVMLMonitor is well-designed with proper initialization and atexit cleanup. The CLI updates to handle legacy flags with deprecation warnings are also a nice touch for backward compatibility. The addition of unit tests for the new functionality is excellent. I have one suggestion in gpu_monitor.py to make the exception handling more specific, but overall this is a solid contribution.

Comment thread src/keep_gpu/utilities/gpu_monitor.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Wangmerlyn
Wangmerlyn merged commit 59873b8 into main Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant