[http] fix: keep asset aliases out of dashboard fallback - #302
Conversation
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 Walkthrough
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the MCP server to correctly handle dot-segment aliases that normalize into the assets directory, ensuring they return a structured JSON 404 error instead of falling back to the dashboard HTML shell. It also updates the documentation and adds corresponding GET and HEAD tests. The feedback suggests simplifying the path containment check in server.py by using Path.is_relative_to(), which is more idiomatic for Python 3.9+.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
fddbc7f to
2fdb7ef
Compare
Summary
AGENTS.mdanddocs/guides/mcp.mdwith the static asset alias contract.Test Plan
PYTHONPATH=src pytest tests/mcp/test_http_api.py::test_http_normalized_asset_alias_returns_404_not_dashboard_index tests/mcp/test_http_api.py::test_http_head_normalized_asset_alias_returns_404_without_body -qfailed before the fix with 200 dashboard responses.PYTHONPATH=src pytest tests/mcp/test_http_api.py::test_http_normalized_asset_alias_returns_404_not_dashboard_index tests/mcp/test_http_api.py::test_http_head_normalized_asset_alias_returns_404_without_body -qPYTHONPATH=src pytest -q tests/mcp/test_http_api.py -k "missing_static_asset or normalized_asset_escape or normalized_asset_alias or head_static_success"PYTHONPATH=src pytest tests/mcp/test_http_api.py -qmkdocs buildpre-commit run --all-files --show-diff-on-failure