[mcp] fix: reject dot-segment route aliases - #295
Conversation
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces normalization for dot-segment path aliases (such as /./api/... and /foo/../api/...) using posixpath.normpath to ensure they consistently return a structured JSON 404 error instead of falling back to static HTML. It includes corresponding documentation updates and comprehensive test coverage. The feedback identifies a redundant conditional check in server.py where the code checks if a normalized path starts with a slash, which is already guaranteed by posixpath.normpath for absolute paths.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
/./api/gpus,/foo/../api/gpus,/./rpc, and/foo/../rpcbefore dashboard/static fallback.404instead of HTML or dashboard content.AGENTS.mdanddocs/guides/mcp.md.Verification
PYTHONPATH=src pytest tests/mcp/test_http_api.py::test_http_dot_segment_api_rpc_aliases_return_json_404_without_static_fallback tests/mcp/test_http_api.py::test_http_dot_segment_api_rpc_alias_unsupported_method_returns_json_404 -qPYTHONPATH=src pytest tests/mcp/test_http_api.py -qPYTHONPATH=src pytest tests/mcp -qmkdocs build --strictpre-commit run --all-files --show-diff-on-failureREADME