Skip to content

[mcp] fix: reject dot-segment route aliases - #295

Merged
Wangmerlyn merged 2 commits into
mainfrom
codex/mcp-dot-segment-routes
Jul 2, 2026
Merged

[mcp] fix: reject dot-segment route aliases#295
Wangmerlyn merged 2 commits into
mainfrom
codex/mcp-dot-segment-routes

Conversation

@Wangmerlyn

Copy link
Copy Markdown
Owner

Summary

  • Reject dot-segment API/RPC aliases like /./api/gpus, /foo/../api/gpus, /./rpc, and /foo/../rpc before dashboard/static fallback.
  • Add HTTP coverage for GET, HEAD, and unsupported-method requests so these routes return structured JSON 404 instead of HTML or dashboard content.
  • Document the invariant in AGENTS.md and docs/guides/mcp.md.

Verification

  • PYTHONPATH=src pytest tests/mcp/test_http_api.py::test_http_dot_segment_api_rpc_aliases_return_json_404_without_static_fallback tests/mcp/test_http_api.py::test_http_dot_segment_api_rpc_alias_unsupported_method_returns_json_404 -q
  • PYTHONPATH=src pytest tests/mcp/test_http_api.py -q
  • PYTHONPATH=src pytest tests/mcp -q
  • mkdocs build --strict
  • pre-commit run --all-files --show-diff-on-failure

README

  • Confirmed the Zenodo DOI badge remains in the README header.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wangmerlyn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c44fa49e-5b78-4589-bb05-f03610d92534

📥 Commits

Reviewing files that changed from the base of the PR and between 0303e53 and 0c17929.

📒 Files selected for processing (4)
  • AGENTS.md
  • docs/guides/mcp.md
  • src/keep_gpu/mcp/server.py
  • tests/mcp/test_http_api.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/mcp-dot-segment-routes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces normalization for dot-segment path aliases (such as /./api/... and /foo/../api/...) using posixpath.normpath to ensure they consistently return a structured JSON 404 error instead of falling back to static HTML. It includes corresponding documentation updates and comprehensive test coverage. The feedback identifies a redundant conditional check in server.py where the code checks if a normalized path starts with a slash, which is already guaranteed by posixpath.normpath for absolute paths.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/keep_gpu/mcp/server.py
@Wangmerlyn
Wangmerlyn merged commit dadd225 into main Jul 2, 2026
6 checks passed
@Wangmerlyn
Wangmerlyn deleted the codex/mcp-dot-segment-routes branch July 2, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant