Skip to content

[dashboard] fix: enforce gpu id list limit - #287

Merged
Wangmerlyn merged 1 commit into
mainfrom
codex/dashboard-gpu-id-limit
Jul 2, 2026
Merged

[dashboard] fix: enforce gpu id list limit#287
Wangmerlyn merged 1 commit into
mainfrom
codex/dashboard-gpu-id-limit

Conversation

@Wangmerlyn

Copy link
Copy Markdown
Owner

Summary

  • reject dashboard GPU ID lists with more than 64 visible ordinals before REST submission
  • add a focused Vitest regression for the 65-ID case
  • rebuild packaged dashboard static assets and document the dashboard parity rule in AGENTS/docs

TDD

  • RED: npm test -- --run src/lib/session.test.js failed because parseGpuIds() accepted a 65-ID unique list
  • GREEN: same command passed after adding the dashboard-side max-list guard

Verification

  • npm test -- --run src/lib/session.test.js
  • npm run build
  • npm test -- --run
  • PYTHONPATH=src pytest tests/test_package_metadata.py tests/mcp/test_http_api.py -q
  • mkdocs build --strict
  • pre-commit run --all-files --show-diff-on-failure
  • local subagent code review: no critical/important/minor issues

Notes

  • README intentionally unchanged to keep the front door compact.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wangmerlyn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d3338ea0-f9d0-41a5-880b-e85084ca1a2d

📥 Commits

Reviewing files that changed from the base of the PR and between 7336831 and 227b7d6.

📒 Files selected for processing (6)
  • AGENTS.md
  • docs/guides/cli.md
  • docs/guides/mcp.md
  • src/keep_gpu/mcp/static/assets/dashboard.js
  • web/dashboard/src/lib/session.js
  • web/dashboard/src/lib/session.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/dashboard-gpu-id-limit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wangmerlyn
Wangmerlyn merged commit 20c606c into main Jul 2, 2026
7 checks passed
@Wangmerlyn
Wangmerlyn deleted the codex/dashboard-gpu-id-limit branch July 2, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant