Skip to content

[api,cli,mcp] fix: reserve dot-segment job ids - #278

Merged
Wangmerlyn merged 1 commit into
mainfrom
codex/job-id-dot-segments
Jul 2, 2026
Merged

[api,cli,mcp] fix: reserve dot-segment job ids#278
Wangmerlyn merged 1 commit into
mainfrom
codex/job-id-dot-segments

Conversation

@Wangmerlyn

@Wangmerlyn Wangmerlyn commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • reject standalone URL dot-segment custom job IDs (. and ..) in the centralized session ID contract
  • keep dotted IDs such as job.123, ..., and a..b valid
  • update CLI/API/MCP docs and AGENTS.md without changing README

Verification

  • Red tests before fix: validator and MCP service cases failed for . and .. because they did not raise
  • PYTHONPATH=src pytest tests/mcp/test_server.py::test_start_keep_rejects_invalid_job_id_before_starting_controller tests/mcp/test_server.py::test_status_rejects_invalid_job_id_without_changing_sessions tests/mcp/test_server.py::test_stop_keep_rejects_invalid_job_id_without_stopping_sessions -q
  • PYTHONPATH=src pytest tests/test_cli_service_commands.py::test_start_command_rejects_local_inputs_before_auto_start tests/test_cli_service_commands.py::test_status_rejects_invalid_job_id_before_rpc tests/test_cli_service_commands.py::test_stop_rejects_invalid_job_id_before_rpc_or_fallback -q
  • PYTHONPATH=src pytest tests/utilities/test_session_config.py tests/mcp/test_server.py::test_start_keep_rejects_invalid_job_id_before_starting_controller tests/mcp/test_server.py::test_status_rejects_invalid_job_id_without_changing_sessions tests/mcp/test_server.py::test_stop_keep_rejects_invalid_job_id_without_stopping_sessions tests/mcp/test_server.py::test_mcp_tools_list_exposes_keepgpu_actions tests/mcp/test_http_api.py::test_http_get_rejects_invalid_decoded_job_id_path tests/test_cli_service_commands.py::test_start_command_rejects_local_inputs_before_auto_start tests/test_cli_service_commands.py::test_status_rejects_invalid_job_id_before_rpc tests/test_cli_service_commands.py::test_stop_rejects_invalid_job_id_before_rpc_or_fallback -q
  • mkdocs build --strict (passes; known Material/MkDocs 2.0 warning)
  • pre-commit run --all-files --show-diff-on-failure
  • PYTHONPATH=src pytest tests -q

Local review

  • Local subagent review found one minor test-symmetry suggestion; addressed by adding CLI and stop-path ./.. cases.
  • Final local subagent review on commit 207b77c6630297a7e589e1e45504f06498708c8b: no critical or important issues; ready to merge.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wangmerlyn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 38f58087-ea67-4cb8-953e-43eace56a61c

📥 Commits

Reviewing files that changed from the base of the PR and between aae62de and 207b77c.

📒 Files selected for processing (10)
  • AGENTS.md
  • docs/guides/cli.md
  • docs/guides/mcp.md
  • docs/reference/api.md
  • docs/reference/cli.md
  • src/keep_gpu/utilities/session_config.py
  • tests/mcp/test_http_api.py
  • tests/mcp/test_server.py
  • tests/test_cli_service_commands.py
  • tests/utilities/test_session_config.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/job-id-dot-segments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@Wangmerlyn
Wangmerlyn merged commit cfca056 into main Jul 2, 2026
6 checks passed
@Wangmerlyn
Wangmerlyn deleted the codex/job-id-dot-segments branch July 2, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant