[global] fix: clean failed startup workers

[Wangmerlyn]

Summary

• best-effort release a child controller that fails after leaving partial worker state during global startup
• keep rollback of already-started children and preserve the original startup error when cleanup fails
• document the global startup cleanup contract in AGENTS.md and architecture docs

Verification

• PYTHONPATH=src pytest tests/global_controller/global_keep_test.py::test_global_keep_releases_failed_controller_with_worker_state -q
• PYTHONPATH=src pytest tests/global_controller/global_keep_test.py::test_global_keep_rolls_back_started_controllers -q
• PYTHONPATH=src pytest tests/global_controller/global_keep_test.py::test_global_keep_preserves_start_error_when_failed_child_cleanup_fails -q
• PYTHONPATH=src pytest tests/global_controller tests/single_gpu_controller/test_release_contract.py -q
• mkdocs build --strict (passes; known Material/MkDocs 2.0 warning)
• pre-commit run --all-files --show-diff-on-failure
• PYTHONPATH=src pytest tests -q

Local review

• Local subagent code review: no critical, important, or minor findings; ready to merge.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Warning

Review limit reached

@Wangmerlyn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6c8f89e6-04a3-47d0-83ba-8f595de5b858

📥 Commits

Reviewing files that changed from the base of the PR and between 5648108 and 83869a2.

📒 Files selected for processing (4)

• AGENTS.md
• docs/concepts/architecture.md
• src/keep_gpu/global_gpu_controller/global_gpu_controller.py
• tests/global_controller/global_keep_test.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/global-startup-failure-cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}