Skip to content

[cli] fix: type stop-all fallback errors - #270

Merged
Wangmerlyn merged 1 commit into
mainfrom
codex/cli-typed-stop-fallback
Jul 1, 2026
Merged

[cli] fix: type stop-all fallback errors#270
Wangmerlyn merged 1 commit into
mainfrom
codex/cli-typed-stop-fallback

Conversation

@Wangmerlyn

Copy link
Copy Markdown
Owner

Summary

  • restrict stop --all daemon fallback to typed service transport failures
  • prevent generic runtime/application timeout messages from force-stopping an ownership-verified daemon
  • document the typed fallback contract in AGENTS.md and the CLI reference

Verification

  • PYTHONPATH=src pytest tests/test_cli_service_commands.py -k "stop_all_fallback or generic_timeout" -q (RED before fix: generic timeout test exited 0)
  • PYTHONPATH=src pytest tests/test_cli_service_commands.py -k "stop_all_fallback or generic_timeout or service_timeout" -q
  • PYTHONPATH=src pytest tests/test_cli_service_commands.py -q
  • mkdocs build --strict
  • pre-commit run --all-files --show-diff-on-failure
  • PYTHONPATH=src pytest tests -q

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wangmerlyn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 17f86c3d-6425-4e57-8893-4e3b9f9b8212

📥 Commits

Reviewing files that changed from the base of the PR and between e8629f3 and 0ea4fe6.

📒 Files selected for processing (4)
  • AGENTS.md
  • docs/reference/cli.md
  • src/keep_gpu/cli.py
  • tests/test_cli_service_commands.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/cli-typed-stop-fallback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wangmerlyn
Wangmerlyn force-pushed the codex/cli-typed-stop-fallback branch from 77e04b3 to 345d531 Compare July 1, 2026 23:28
@Wangmerlyn
Wangmerlyn force-pushed the codex/cli-typed-stop-fallback branch from 345d531 to 0ea4fe6 Compare July 1, 2026 23:32
@Wangmerlyn
Wangmerlyn merged commit b277a4a into main Jul 1, 2026
6 checks passed
@Wangmerlyn
Wangmerlyn deleted the codex/cli-typed-stop-fallback branch July 1, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant