Skip to content

[mcp] fix: reject leading slash route aliases - #242

Merged
Wangmerlyn merged 1 commit into
mainfrom
codex/rpc-leading-slash-routes
Jul 1, 2026
Merged

[mcp] fix: reject leading slash route aliases#242
Wangmerlyn merged 1 commit into
mainfrom
codex/rpc-leading-slash-routes

Conversation

@Wangmerlyn

Copy link
Copy Markdown
Owner

Summary

  • reject raw leading-double-slash API/RPC aliases before REST side effects or JSON-RPC parsing
  • add raw-socket regressions for //api/sessions, //api/sessions/{job_id}, and //rpc
  • document the noncanonical route contract in AGENTS.md and API docs

Verification

  • PYTHONPATH=src pytest tests/mcp/test_http_api.py -q -k 'raw_double_slash or content_length'
  • PYTHONPATH=src pytest tests/mcp/test_http_api.py -q
  • PYTHONPATH=src pytest tests -q
  • mkdocs build --strict
  • pre-commit run --all-files --show-diff-on-failure
  • git diff --check

Notes

  • README is untouched and keeps the Zenodo DOI badge.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wangmerlyn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 83181e84-b744-4e3c-81ed-e1b0e34c726b

📥 Commits

Reviewing files that changed from the base of the PR and between 315695c and 7e7ec9a.

📒 Files selected for processing (6)
  • AGENTS.md
  • docs/guides/mcp.md
  • docs/plans/rpc-leading-slash-routes.md
  • docs/reference/cli.md
  • src/keep_gpu/mcp/server.py
  • tests/mcp/test_http_api.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/rpc-leading-slash-routes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where Python's BaseHTTPRequestHandler collapses request targets starting with // before route checks, which could allow noncanonical routes like //api/sessions or //rpc to bypass checks. The changes extract the raw request target from the request line, detect leading double slashes, and reject them with a structured JSON 404 Unknown endpoint response. The PR also includes comprehensive documentation updates and regression tests to verify this behavior. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Wangmerlyn
Wangmerlyn merged commit 0d22f6f into main Jul 1, 2026
6 checks passed
@Wangmerlyn
Wangmerlyn deleted the codex/rpc-leading-slash-routes branch July 1, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant