[mcp] fix: reject leading slash route aliases - #242
Conversation
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where Python's BaseHTTPRequestHandler collapses request targets starting with // before route checks, which could allow noncanonical routes like //api/sessions or //rpc to bypass checks. The changes extract the raw request target from the request line, detect leading double slashes, and reject them with a structured JSON 404 Unknown endpoint response. The PR also includes comprehensive documentation updates and regression tests to verify this behavior. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
//api/sessions,//api/sessions/{job_id}, and//rpcVerification
PYTHONPATH=src pytest tests/mcp/test_http_api.py -q -k 'raw_double_slash or content_length'PYTHONPATH=src pytest tests/mcp/test_http_api.py -qPYTHONPATH=src pytest tests -qmkdocs build --strictpre-commit run --all-files --show-diff-on-failuregit diff --checkNotes