[ci] fix: keep pre-commit workflow lean - #194
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe pre-commit CI workflow is changed to install only ChangesPre-commit CI slim install
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates documentation in AGENTS.md and docs/contributing.md to specify that pre-commit CI should only install the pre-commit runner and avoid installing runtime dependencies. It also adds a test in tests/test_ci_workflows.py to enforce this rule. Feedback was provided to make the test more robust by handling both .yaml and .yml extensions and using regular expressions instead of exact string matching for pip install commands.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3c9c1f3 to
ee6c89e
Compare
ee6c89e to
d80039a
Compare
Summary
pre-commitrunner in pre-commit CI instead of installing KeepGPU with dev extras.Test Plan
PYTHONPATH=$PWD/src pytest tests/test_ci_workflows.py -qpre-commit run --all-files --show-diff-on-failuremkdocs build --strict(only upstream Material warning)Review
Summary by CodeRabbit
Bug Fixes
Documentation
Tests