Skip to content

Tasicarlo issues 369, 370#371

Draft
og113 wants to merge 7 commits into
mainfrom
tasicarlo-issue-370
Draft

Tasicarlo issues 369, 370#371
og113 wants to merge 7 commits into
mainfrom
tasicarlo-issue-370

Conversation

@og113

@og113 og113 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Deals with the raised in Issues #369 and #370, plus a couple small things:

  • Comment about IDM renormalisation added to Model file
  • Comment about git-lfs added to docs installation instructions
  • WallGo.__version__ added to __init__.py, updated dynamically, and tested in tests/test_version.py
  • removed WallGoCollision import fail warning
  • added list of papers that have used WallGo to docs
  • fixed small bug in validation of interpolation table
  • fixed unpacking of 5 instead of 7 items in calls to EOM.wallPressure within EOM.findWallVelocityDetonation

Note that the updated docs for this PR can be read here: https://wallgo.readthedocs.io/en/tasicarlo-issue-370/

I've decided to make this PR now, as a reference for discussion, but some things still need doing:

@og113 og113 marked this pull request as draft June 9, 2026 11:15
@og113

og113 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Of the issues remaining, the easiest win is to expose forceImproveConvergence in WallGo's settings, so it can be set to True by the user.

@og113

og113 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Of the issues remaining, the easiest win is to expose forceImproveConvergence in WallGo's settings, so it can be set to True by the user.

This is done now.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this choice was deliberate by following other papers, I wouldn't add here an acknowledgment but rather in reply to the issue.

@pschicho pschicho left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks Oli. Had a few small questions.

Comment thread src/WallGo/__init__.py
"WallGoCollision, or both. This is non-fatal, but you will not be able to"
" utilize collision integration routines."
)
pass # no longer printing warning to stdout

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue was that this message was displayed even when the collision module was loaded. But now it wouldn't display at all, right?

self._validateInterpolationTable(self._rangeMin)
self._validateInterpolationTable(self._rangeMax)
self._validateInterpolationTable((self._rangeMax - self._rangeMin) / 2.55)
self._validateInterpolationTable(self._validateInterpolationTable(self._rangeMin + 0.3 * (self._rangeMax - self._rangeMin)))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this self nesting cause any issues here?
Why not just write
self._validateInterpolationTable(self._rangeMin + 0.3 * (self._rangeMax - self._rangeMin))


The `.hdf5` collision files packaged with WallGo are tracked with `git-lfs <https://git-lfs.com/>`_, so that to download them, you also need to run::

git lfs install

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make clear that this needs to be done only once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants