Tasicarlo issues 369, 370#371
Conversation
|
Of the issues remaining, the easiest win is to expose |
This is done now. |
There was a problem hiding this comment.
Since this choice was deliberate by following other papers, I wouldn't add here an acknowledgment but rather in reply to the issue.
pschicho
left a comment
There was a problem hiding this comment.
Looks very good, thanks Oli. Had a few small questions.
| "WallGoCollision, or both. This is non-fatal, but you will not be able to" | ||
| " utilize collision integration routines." | ||
| ) | ||
| pass # no longer printing warning to stdout |
There was a problem hiding this comment.
I think the issue was that this message was displayed even when the collision module was loaded. But now it wouldn't display at all, right?
| self._validateInterpolationTable(self._rangeMin) | ||
| self._validateInterpolationTable(self._rangeMax) | ||
| self._validateInterpolationTable((self._rangeMax - self._rangeMin) / 2.55) | ||
| self._validateInterpolationTable(self._validateInterpolationTable(self._rangeMin + 0.3 * (self._rangeMax - self._rangeMin))) |
There was a problem hiding this comment.
Can this self nesting cause any issues here?
Why not just write
self._validateInterpolationTable(self._rangeMin + 0.3 * (self._rangeMax - self._rangeMin))
|
|
||
| The `.hdf5` collision files packaged with WallGo are tracked with `git-lfs <https://git-lfs.com/>`_, so that to download them, you also need to run:: | ||
|
|
||
| git lfs install |
There was a problem hiding this comment.
Maybe make clear that this needs to be done only once
Deals with the raised in Issues #369 and #370, plus a couple small things:
WallGo.__version__added to__init__.py, updated dynamically, and tested intests/test_version.pyWallGoCollisionimport fail warningEOM.wallPressurewithinEOM.findWallVelocityDetonationNote that the updated docs for this PR can be read here: https://wallgo.readthedocs.io/en/tasicarlo-issue-370/
I've decided to make this PR now, as a reference for discussion, but some things still need doing:
findWallVelocityDetonationunpacks 5 values from a 7-tuple + (2) hybrid-regime singular Boltzmann matrix #370