Move test helpers to dedicated module#125
Merged
Merged
Conversation
|
SarahAlidoost
approved these changes
Jun 10, 2026
SarahAlidoost
left a comment
SarahAlidoost
left a comment
Collaborator
There was a problem hiding this comment.
As discussed, only please keep get_test_data and prepare_engine_input in utils as notebooks use them. Thanks! 👍
5 tasks
Collaborator
Author
Unfortunately, this turns out not to help to solve the circular import issue. I will still move |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #124 I wanted to import some functions from
utils.pytoengine.py- this is currently not possible due to circular imports. With this PR I am only moving the test helper functions to a new module (test.py), so that circular imports are solved. I think this will also draw a clearer separation between utility functions actively used in diffwofost and functions used only to support tests.