Skip to content

Fix data splitting for S2BMS UC#119

Merged
gabrieletijunaityte merged 8 commits into
developfrom
feature/data_splits
Jun 17, 2026
Merged

Fix data splitting for S2BMS UC#119
gabrieletijunaityte merged 8 commits into
developfrom
feature/data_splits

Conversation

@gabrieletijunaityte

@gabrieletijunaityte gabrieletijunaityte commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Clean up datasplits, add their explanations. Prepares datasplits (S2BMS and unlabelled) that:

  • Share val-test portions.

  • Training set is filtered based on data availability per modality.

  • Additionally some missed before test fixes.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?

@vdplasthijs vdplasthijs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor; I think the explanations txt file should be updated? Please go ahead and merge when it's ready!

Comment thread data/s2bms/splits/explanations.txt
@gabrieletijunaityte gabrieletijunaityte merged commit 44cf05a into develop Jun 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants