Fix data splitting for S2BMS UC#119
Merged
Merged
Conversation
vdplasthijs
approved these changes
Jun 16, 2026
vdplasthijs
left a comment
Collaborator
There was a problem hiding this comment.
Very minor; I think the explanations txt file should be updated? Please go ahead and merge when it's ready!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clean up datasplits, add their explanations. Prepares datasplits (S2BMS and unlabelled) that:
Share val-test portions.
Training set is filtered based on data availability per modality.
Additionally some missed before test fixes.
Before submitting
pytestcommand?