Full Stack Developer Test Submission - Ashwini#12
Open
Ashwini270999 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
I have completed the full-stack test assignment. Here is a clear breakdown of what I worked on and the changes I implemented:
• Form Validations: Added proper data cleaning via PHP trim() and required field checks for text fields on both create and edit pages. Added required and accept tags on the frontend inputs to help guide the user.
• Safe File Uploads: Integrated PHP's finfo file checker on the backend to verify the actual file type of image uploads, preventing invalid or bad files from uploading.
• Atomic Image Management: Adjusted the update logic so that an old slide image is only deleted from the folder after the database successfully confirms the record update. If the user edits a slide without changing the image, the current image is safely retained.
• Clean Code Structure: Moved all inline custom CSS into its own external style.css file, and moved the jQuery slider/accordion logic into slider-accordion.js to keep the main index.php clean and readable.
• Delete Confirmation: Added a standard JavaScript alert box to confirm before a user accidentally deletes a slide from the dashboard.
• Technical Questions: Answered all 3 evaluation questions clearly inside the Answers to technical questions.md file in the root folder.
Please let me know if you need any adjustments or further details. Looking forward to your feedback!